hersi
/
ExperimentalGear
1
0
Fork 0
Code Issues 14 Pull Requests Projects 1 Releases 6 Activity

Get basic ht anims working #15

Merged
local merged 2 commits from feat/local/hitfx into master 2022-04-27 02:04:45 +02:00
Conversation 0 Commits 2 Files Changed 42 +601 -270
local commented 2022-04-27 00:14:46 +02:00
Collaborator
Copy Link

This includes classes for Image and Animation with documentation as well as some minor refactors of existing code to make the implementation easier.

This includes classes for Image and Animation with documentation as well as some minor refactors of existing code to make the implementation easier.
local added 1 commit 2022-04-27 00:14:46 +02:00
local requested review from hersi 2022-04-27 01:20:43 +02:00
local requested review from Kuenaimaku 2022-04-27 01:20:43 +02:00
hersi requested changes 2022-04-27 01:21:34 +02:00
scripts/common.lua Outdated
@ -20,6 +20,7 @@ Memo.memoize = function(this, key, generator)
return value
end
--[[
hersi commented 2022-04-27 01:01:01 +02:00
Owner
Copy Link

let's just delete this file...

let's just delete this file...
hersi marked this conversation as resolved
scripts/common.lua Outdated
@ -132,2 +133,4 @@
]]
function GetDisplayDifficulty(jacketPath, difficulty)
hersi commented 2022-04-27 01:01:27 +02:00
Owner
Copy Link

could maybe go into common/globals.lua?

could maybe go into common/globals.lua?
hersi marked this conversation as resolved
scripts/common.lua Outdated
@ -159,1 +164,4 @@
return result;
end
function firstAlphaNum(s)
hersi commented 2022-04-27 00:53:16 +02:00
Owner
Copy Link

could instead go into common/utils.lua

could instead go into common/utils.lua
hersi marked this conversation as resolved
scripts/common.lua Outdated
@ -160,0 +180,4 @@
---@param y number
---@param rotation number
---@return number, boolean # The scale applied to the transform and the current landscape state
function setUpTransforms(x, y, rotation)
hersi commented 2022-04-27 00:57:16 +02:00
Owner
Copy Link

unnecessary, common/dimensions.lua already has this function

local Dim = require("common/dimensions")

function render(deltaTime)
    Dim.updateResolution() --optional if it's a component, only useful in screen rendering function
    Dim.transformToScreenSpace()
end
unnecessary, common/dimensions.lua already has this function ```lua local Dim = require("common/dimensions") function render(deltaTime) Dim.updateResolution() --optional if it's a component, only useful in screen rendering function Dim.transformToScreenSpace() end ```
hersi marked this conversation as resolved
local added 1 commit 2022-04-27 02:04:31 +02:00
local merged commit b07d72879c into master 2022-04-27 02:04:45 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
hersi
Kuenaimaku
Labels
Clear labels   
asset

Asset related issue

  
bug

Something is not working

  
code

Script Code related issue

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
glsl

Shader Code related issue

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
asset
bug
code
duplicate
enhancement
glsl
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hersi/ExperimentalGear#15
No description provided.
Delete Branch "feat/local/hitfx"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?